Diagnostics for Bulk Stream #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
reviewed
Sep 8, 2019
j82w
reviewed
Sep 8, 2019
Microsoft.Azure.Cosmos/src/Resource/Settings/ItemBatchOperationStatistics.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/Settings/ItemBatchOperationStatistics.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/Settings/ItemBatchOperationStatistics.cs
Show resolved
Hide resolved
abhijitpai
reviewed
Sep 8, 2019
abhijitpai
previously approved these changes
Sep 8, 2019
kirankumarkolli
approved these changes
Sep 11, 2019
|
|
j82w
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR wires Diagnostics from the ResponseMessage to the BatchResponse (enabling Diagnostics for Batch API) and subsequently, to the ItemOperationContext that will hold them until the operation Completes.
In the case of retries, multiple Diagnostics for each operation will exist, hence the introduction of
ItemBatchOperationStatistics, which will hold all single Diagnostics and wire them to the final operation Diagnostics when sent to the caller.Type of change
Please delete options that are not relevant.
Closes #691, related to #584